Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

download_data.py fails if dryrun log filename contains uppercase characters #2633

Closed
ihough opened this issue Oct 10, 2024 · 2 comments · May be fixed by #2508
Closed

download_data.py fails if dryrun log filename contains uppercase characters #2633

ihough opened this issue Oct 10, 2024 · 2 comments · May be fixed by #2508
Assignees
@yantosca
Labels
category: Bug Something isn't working topic: Dry-Run Simulation Related to GEOS-Chem dry-run

Comments

@ihough
Copy link

ihough commented Oct 10, 2024

Your name

Ian Hough

Your affiliation

Université Grenoble Alpes

What happened? What did you expect to happen?

When using the download_data.py script to download input data from a dryrun simulation, the script fails if the dryrun log filename contains uppercase characters.

What are the steps to reproduce the bug?

To reproduce, from a configured run dir on a case-sensitive file system:

./gcclassic --dryrun | tee Log.dryrun
./download_data.py Log.dryrun washu

The output will be something like:

Traceback (most recent call last):
  File "/home/PROJECTS/pr-geoschem/gcclassic-runs/gc_4x5_merra2_fullchem/./download_data.py", line 782, in <module>
    main()
    ~~~~^^
  File "/home/PROJECTS/pr-geoschem/gcclassic-runs/gc_4x5_merra2_fullchem/./download_data.py", line 778, in main
    download_the_data(parse_args())
    ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "/home/PROJECTS/pr-geoschem/gcclassic-runs/gc_4x5_merra2_fullchem/./download_data.py", line 661, in download_the_data
    paths = extract_pathnames_from_log(args)
  File "/home/PROJECTS/pr-geoschem/gcclassic-runs/gc_4x5_merra2_fullchem/./download_data.py", line 110, in extract_pathnames_from_log
    with open(dryrun_log, "r", encoding="UTF-8") as ifile:
         ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'log.dryrun'

Please attach any relevant configuration and log files.

No response

What GCClassic version were you using?

14.4.3

What environment were you running GCClassic on?

Local cluster

What compiler and version were you using?

gcc 14.1.0, gfortran 14.1.0

Will you be addressing this bug yourself?

Yes

Additional information

No response
@ihough ihough added the category: Bug Something isn't working label Oct 10, 2024
@ihough ihough mentioned this issue Oct 10, 2024
Open
@yantosca yantosca self-assigned this Nov 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2024

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the issue from closing this issue.

@github-actions github-actions bot added the stale No recent activity on this issue label Dec 8, 2024
@yantosca yantosca transferred this issue from geoschem/GCClassic Dec 12, 2024
@yantosca yantosca linked a pull request Dec 12, 2024 that will close this issue
Bug fix: allow uppercase log filename in download_data.py #2508
Open
@yantosca
Copy link
Contributor

Note: This is fixed by #2508, which will ship with GEOS-Chem 14.5.1. PR #2508 will be closed once the dev/no-diff-to-benchmark is merged into main (I forgot to change the branch to dev/no-diff-to-benchmark). We can close this as completed.

@yantosca yantosca added topic: Dry-Run Simulation Related to GEOS-Chem dry-run and removed stale No recent activity on this issue labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yantosca yantosca

Labels
category: Bug Something isn't working topic: Dry-Run Simulation Related to GEOS-Chem dry-run
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug fix: allow uppercase log filename in download_data.py ihough/geos-chem
2 participants
@ihough @yantosca