Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Online H2 chemistry from Perez-Peña et al. (2022) #1867

Open
msulprizio opened this issue Jul 11, 2023 · 11 comments · May be fixed by #1871
Open

[FEATURE REQUEST] Online H2 chemistry from Perez-Peña et al. (2022) #1867

msulprizio opened this issue Jul 11, 2023 · 11 comments · May be fixed by #1871
Labels
category: Feature Request New feature or request deferred Issues/PRs that we cannot work on right away topic: Chemical Mechanisms Related to KPP and/or GEOS-Chem chemistry mechanisms

Comments

@msulprizio
Copy link
Contributor

msulprizio commented Jul 11, 2023 •
edited
Loading

@mpperezp implemented online H2 capability as described in https://acp.copernicus.org/articles/22/12367/2022/acp-22-12367-2022.html.

@jennyfisher wrote:

Maria Paula’s code is here: https://github.com/mpperezp/geos-chem

She forked from a recent version, set it back to the original v12.5, and added all her updates in a single commit in branch called h2_model.

We think most of the changes are in parts of the code that haven’t changed substantially:

  • In HEMCO, addition of a species to GFED inventories (easy update)
  • In KPP, a few small changes to Standard.eqn (moving H2 from fixed to variable and adding it as a product from a few existing reactions)
  • Updates to treatment of H2 in the UCX code, dry dep code, and species_database.

Beyond the code, it’s just some config file updates and input datasets (which Maria Paula can share when needed).

It is not its own specialty simulation but rather an addition to the fullchem simulation. However, it is not strongly affected by any of the rest of the chemistry (e.g. halogens), so shouldn’t need to be re-validated in v14.

@mpperezp also noted:

Part of the development includes the use of H2 dry deposition velocity fields that were provided to me by Hisashi Yashiro (from his work and this information is not yet publicly available. Hisashi Yashiro informs us that he needs to first publish the information on the website of his centre (https://db.cger.nies.go.jp/ged/en/), a process that can take up to 6 months.
@msulprizio msulprizio changed the title [FEATURE REQUEST] Online H2 chemistry from Perez-Pena et al. (2022) [FEATURE REQUEST] Online H2 chemistry from Perez-Peña et al. (2022) Jul 11, 2023
@msulprizio msulprizio mentioned this issue Jul 11, 2023
Closed
@mpperezp mpperezp linked a pull request Jul 12, 2023 that will close this issue
Open
@yantosca yantosca added the topic: Chemical Mechanisms Related to KPP and/or GEOS-Chem chemistry mechanisms label Jul 19, 2023
@yantosca yantosca linked a pull request Aug 1, 2023 that will close this issue
H2 modelling capability #1871
Open
@jennyfisher
Copy link
Contributor

We have now been informed by our collaborator Hisashi Yashiro that the H2 deposition database has been released (with DOI) and is available at: https://www.nies.go.jp/doi/10.17595/20230901.001-e.html

When this capability is added to GEOS-Chem, can you make sure to update the GC narrative and new development pages to ensure citation information includes both Pérez-Peña et al. 2022 and the doi-based citation for this dataset that we use?

Thanks!

@laura-hyesung-yang
Copy link

@msulprizio Hi Melissa, can I ask which version of GEOS-Chem this new feature would be added to?

@msulprizio
Copy link
Contributor Author

@laura-hyesung-yang We're wrapping up 14.3.0 now for benchmarking in January, so this won't go in until at least 14.4.0

@laura-hyesung-yang
Copy link

@msulprizio Thank you for the update!

@msulprizio
Copy link
Contributor Author

Hi @laura-hyesung-yang. I am confirming that the Chemistry WG has prioritized this update for 14.4.0 which we aim to release by IGC11 (June 2024).

@laura-hyesung-yang
Copy link

@msulprizio Thank you for the update!

@laura-hyesung-yang
Copy link

@msulprizio @yantosca Hi Melissa and Bob, I see online H2 chemistry under "Ready to go in" section don't see in wiki page for GCClassic 14.4.0. May I ask if this integration has been cancelled from priority? Thank you!

@msulprizio
Copy link
Contributor Author

@laura-hyesung-yang Yes, it will be discussed at IGC11 in June.

@yantosca yantosca reopened this Apr 29, 2024
@yantosca yantosca added the deferred Issues/PRs that we cannot work on right away label Apr 29, 2024
@laura-hyesung-yang
Copy link

@msulprizio Thanks for the update, Melissa! No urgency (currently pursuing a way to treat H2 like CH4) but just wished to check.

@jennyfisher
Copy link
Contributor

FYI neither Maria Paula nor I will be at IGC so please let us know in advance if there are any questions. Laura, you're welcome to check our Maria's code directly if you want to work in an older GC version.

@laura-hyesung-yang
Copy link

@jennyfisher Thank you for letting me know! I will keep you updated if I have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: Feature Request New feature or request deferred Issues/PRs that we cannot work on right away topic: Chemical Mechanisms Related to KPP and/or GEOS-Chem chemistry mechanisms
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

H2 modelling capability mpperezp/geos-chem
4 participants
@jennyfisher @msulprizio @yantosca @laura-hyesung-yang