Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace whitespace with underscores in benchmark plot/table version labels and file names #316

Closed
1 task done
yantosca opened this issue Apr 23, 2024 · 2 comments · Fixed by #340
Closed
1 task done
Assignees
Labels
category: Feature Request New feature or request topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output
Milestone

Comments

@yantosca
Copy link
Contributor

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Confirm you have reviewed the following documentation

New GCPy feature or discussion

We propose replacing spaces and tabs with "_" characters in benchmark plot and table file names and version strings. Currently, it is possible to specify a version string with spaces, e.g.:

data:
  ref:
    gcc:
      version: gcc 14.2.0 rc 0
      ...
    gchp:
      version: gchp 14.2.0 rc 0
  ...
  dev:
    gcc:
      version: gcc 14.2.0 rc 2
      ...
    gchp:
      version: gchp 14.2.0 rc 2
       ...

and this would result in several file names for benchmark plots and tables having spaces in them.

@yantosca yantosca added category: Feature Request New feature or request topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output labels Apr 23, 2024
@yantosca yantosca self-assigned this Apr 23, 2024
@yantosca yantosca added this to the 1.5.0 milestone Apr 23, 2024
@yantosca
Copy link
Contributor Author

NOTE: PR #319 contains a new function named replace_whitespace that will strip whitespace from labels and file names. It has been applied to some of the newer benchmark scripts but needs to be applied to all benchmark scripts.

@yantosca
Copy link
Contributor Author

yantosca commented Oct 7, 2024

This issue can now be closed as PR #340 has been merged into the GCPy 1.6.0 development stream.

@yantosca yantosca closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant