Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file_regrid.py creates GCHP restart files with variable name DELPDRY instead of DELP_DRY #296

Closed
3 tasks done
yantosca opened this issue Feb 1, 2024 · 1 comment · Fixed by #297
Closed
3 tasks done
Assignees
Labels
category: Bug Something isn't working topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output topic: Regridding Issues pertaining to horizontal & vertical regridding
Milestone

Comments

@yantosca
Copy link
Contributor

yantosca commented Feb 1, 2024

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Confirm you have reviewed the following documentation

Description of your issue or question

When using file_regrid.py to create a GCHP restart file from a GCClassic restart file, the dry pressure variable is created using the wrong name (DELPDRY). The correct name should be DELP_DRY.

To reproduce :

$ python -m gcpy.file_regrid --filein GEOSChem.Restart.20190101_0000z.nc4 \
       --dim_format_in classic \
       --fileout GEOSChem.Restart.20190101_0000z.c24.nc4 \
       --cs_res_out 24 \
       --dim_format_out checkpoint
$ ncdump -cts GEOSChem.Restart.20190101_0000z.c24.nc4 | grep "DELP"

Output:

        float DELPDRY(time, lev, lat, lon) ;
                DELPDRY:_FillValue = NaNf ;
                DELPDRY:long_name = "Delta-pressure across grid box (dry air)" ;
                DELPDRY:units = "hPa" ;
                DELPDRY:averaging_method = "instantaneous" ;
                DELPDRY:_Storage = "chunked" ;
                DELPDRY:_ChunkSizes = 1, 72, 144, 24 ;
                DELPDRY:_Endianness = "little" ;

This causes benchmark plotting jobs (i.e. budget_ox.py) to fail, since the plotting code is looking for the wrong name.

I will make a PR with a fix.

Tagging @msulprizio @lizziel

@yantosca yantosca added category: Bug Something isn't working topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output topic: Regridding Issues pertaining to horizontal & vertical regridding labels Feb 1, 2024
@yantosca yantosca self-assigned this Feb 1, 2024
@yantosca
Copy link
Contributor Author

yantosca commented Feb 1, 2024

PR #297 is now merged into dev, so we can close this issue.

@yantosca yantosca added this to the 1.4.3 milestone Feb 1, 2024
@yantosca yantosca closed this as completed Feb 1, 2024
@yantosca yantosca modified the milestones: 1.4.3, 1.5.0 Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Something isn't working topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output topic: Regridding Issues pertaining to horizontal & vertical regridding
Projects
None yet
1 participant