Fix GCHPctmEnv small numerical bugs #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update #1 affects only GCHP runs that import mass fluxes from offline meteorology which makes this a zero diff update for benchmarking. I will therefore put milestone 14.5.1. |
lizziel
added
topic: Runtime
yuanjianz
force-pushed
the
bugfix/gchp-advection-small-numerical-bugs
branch
from
bf79029 to
4023750
Compare
lizziel
requested changes
Nov 15, 2024
src/GCHP_GridComp/GCHPctmEnv_GridComp/GCHPctmEnv_GridCompMod.F90
Outdated
Show resolved
Hide resolved
lizziel
approved these changes
Nov 18, 2024
lizziel
force-pushed
the
bugfix/gchp-advection-small-numerical-bugs
branch
from
85979ae to
47f4160
Compare
|
@yuanjianz, I am rebasing to avoid merge conflicts and streamline the git history when I bring this into dev/no-diff-to-benchmark. |
# Conflicts: # CHANGELOG.md Signed-off-by: Lizzie Lundgren <[email protected]>
lizziel
force-pushed
the
bugfix/gchp-advection-small-numerical-bugs
branch
from
47f4160 to
2641547
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Yuanjian Zhang
Institution: WashU
Describe the update
Expected changes
Related Github Issue
closes #445
closes #455