Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to use different types for Point::Scalar and square #145

Closed
stepancheg opened this issue Dec 24, 2023 · 1 comment
Closed

Need to use different types for Point::Scalar and square #145

stepancheg opened this issue Dec 24, 2023 · 1 comment

Comments

@stepancheg
Copy link

If scalar is i32, distance squared is i64.

But currently RTree in operations like RTree::locate_within_distance assumes distance squared is the same type as scalar.

The workaround is for user to store data keyed by i64 when data fits within i32. This is somewhat inefficient.
@stepancheg stepancheg changed the title Need to use different scalars for Point::Scalar and square Need to use different types for Point::Scalar and square Dec 24, 2023
@adamreichold
Copy link
Member

Duplicate of #48

@adamreichold adamreichold marked this as a duplicate of #48 Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stepancheg @adamreichold