Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when importing from chefkoch.de #278

Open
Saturo78 opened this issue Dec 22, 2022 · 7 comments · May be fixed by #503
Open

Error when importing from chefkoch.de #278

Saturo78 opened this issue Dec 22, 2022 · 7 comments · May be fixed by #503

Comments

@Saturo78
Copy link

When processing a recipe from chefkoch.de i get the error message:

Error
steps.map is not a function

@dotnjet
Copy link

dotnjet commented Apr 20, 2023

dito

@4-FLOSS-Free-Libre-Open-Source-Software

Something went wrong
Could not parse steps

@GyrosWookiedaris
Copy link

I second this. This makes recipe buddy barely unusable for my usecase, sadly.

@jannavischer
Copy link

Same here, with the 'Something went wrong Could not parse steps' -error :(

@JohannesFleischer
Copy link

If i see this correctly an array is expected when trying to parse the recipeInstructions.

const steps = RecipeStepSchema.array().safeParse(

But chefkoch stored the instructions in a string:

"recipeInstructions": "Die Nudeln kochen [...] und mit dem geriebenen Parmesan garnieren."

This recipe for example seems to work, which stores the steps as an list of HowToStep objects.

But i have no clue about typescript

@JohannesFleischer
Copy link

JohannesFleischer commented Oct 15, 2024

Nexcloud cookbook is by the way able to parse it. Maybe this is a good reference implementation.

@JohannesFleischer
Copy link

I just created an MR to address this issue. If you want to test the changes / use them already you can clone the repo swap in my changes and then build the docker container yourself. That is at least how I tested my changes. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants