Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with MapStore v2022.02.00 #178

Open
Gaetanbrl opened this issue Dec 6, 2022 · 1 comment
Open

Compatibility with MapStore v2022.02.00 #178

Gaetanbrl opened this issue Dec 6, 2022 · 1 comment

Comments

@Gaetanbrl
Copy link

Gaetanbrl commented Dec 6, 2022

Hi,

It appear that mapstore2-cadastrapp seems not align (compatible ?) with MapStore v2022.02.00.

Indeed, the doc talk about :

Starting with MapStore v2022.02.00, layout improvements have been introduced which, in addition to other changes, introduce a new sidebar menu to be used instead of the burger menu.

So, to be compatible, some dev need to :

  1. Use mapLayoutValuesSelector ==> OK already satisfy

https://github.com/georchestra/mapstore2-cadastrapp/blob/a758212a3276123476f4d7c31a4a8605a2944d74/js/extension/selectors/maplayout.js

  1. Replace DockPanel, DockablePanel, ContainerDimensions (if used) with the ResponsiveContainer ==> KO not stasisfy

<DockContainer
dockStyle={dockStyle}
id="cadastrapp-container"
style={{pointerEvents: 'none'}}
>
<ContainerDimensions>
{({ width }) => (<DockPanel

@Gaetanbrl
Copy link
Author

Gaetanbrl commented Dec 6, 2022

In addition, a DockContainer component seems added before some MapStore2 enhancement and is not provided by MapStore2 (as said by this commit to Applying necessary changes to cadastrapp to support MapStore layout) :

https://github.com/georchestra/mapstore2-cadastrapp/blob/a758212a3276123476f4d7c31a4a8605a2944d74/js/extension/components/misc/panels/DockContainer.jsx

Just to understand :

Why don't use native MapStore2 component (e.g ResponsivePanel + dockPanel ) ? Is it something to do in the futur ?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant