Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong version #525

Closed
huard opened this issue Mar 16, 2020 · 7 comments
Closed

Wrong version #525

huard opened this issue Mar 16, 2020 · 7 comments
Labels
Milestone

Comments

@huard
Copy link
Collaborator

huard commented Mar 16, 2020

Description

Master still has __version__ set to 4.2.2 even though it has been tagged with 4.2.4.

@tlvu
Copy link
Collaborator

tlvu commented Mar 16, 2020

__init__.py still hardcode 4.2.2 on head of branch master:

__version__ = '4.2.2'

@cehbrecht cehbrecht added the bug label Mar 17, 2020
@cehbrecht
Copy link
Collaborator

we don't use bumpversion ... so we got these inconsistencies. Should we create a 4.2.x branch and fix the release, introduce bumpversion and make a 4.2.5 release?

ping @jachym

@cehbrecht
Copy link
Collaborator

we don't use bumpversion ... so we got these inconsistencies. Should we create a 4.2.x branch and fix the release, introduce bumpversion and make a 4.2.5 release?

ping @jachym

@huard @davidcaron do you agree?

@huard
Copy link
Collaborator Author

huard commented Mar 23, 2020

For us, bumpversion has simplified releases, so I would recommend its use in pywps.

I don't think there is a rush for us to get a new version out, so this change could happen with the next planned release.

@Zeitsperre Would you have time to submit a PR ?

@Zeitsperre
Copy link
Collaborator

@huard Sure. I can add something fairly easily.

@Zeitsperre
Copy link
Collaborator

@cehbrecht @huard feel free to weigh in on the PR. Also, I don't think I have privileges here; Think I could be added to the group if I'm not listed?

@cehbrecht cehbrecht added this to the 5.0.0 milestone Mar 24, 2020
@cehbrecht
Copy link
Collaborator

@Zeitsperre I have send you an invitation for write access. I close this issue ... will use bumpversion for the next release (#527)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants