-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When geopandas is available, pyogrio expects pyproj to be available #456
Comments
Good point, we should update our importing of pyproj and provide a better error message if it is not available. |
Although #452 already updates the one place where we import pyproj? |
Yes, after making this issue I noticed it was easy to just remove the import... |
Back to the drawing board... I added pyproj previously to the environment file to focus the test on the switch to What is the way forward? Add |
When we allowed geopandas without pyproj, we had to change quite a lot of tests as the expected value for CRS changes to None. If we want to properly do it here, we might need to follow the same model. We should allow pyogrio without pyproj to support this model in geopandas so I wouldn't add it necessarily as a conda dependency. |
It should be OK now in #452: no more failing tests when |
Since geopandas 1.0, geopandas-base doesn't imply anymore that pyproj will be installed as well.
But, pyogrio now expects it to be.
Noticed in #452.
The text was updated successfully, but these errors were encountered: