Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When geopandas is available, pyogrio expects pyproj to be available #456

Closed
theroggy opened this issue Jul 26, 2024 · 6 comments · Fixed by #452
Closed

When geopandas is available, pyogrio expects pyproj to be available #456

theroggy opened this issue Jul 26, 2024 · 6 comments · Fixed by #452
Assignees

Comments

@theroggy
Copy link
Member

theroggy commented Jul 26, 2024

Since geopandas 1.0, geopandas-base doesn't imply anymore that pyproj will be installed as well.

But, pyogrio now expects it to be.

Noticed in #452.

@theroggy theroggy changed the title When geopandas is available, pyogrio now expects pyjroj is available as well, which is not the case anymore. When geopandas is available, pyogrio expects pyjroj to be available Jul 26, 2024
@theroggy theroggy changed the title When geopandas is available, pyogrio expects pyjroj to be available When geopandas is available, pyogrio expects pyproj to be available Jul 26, 2024
@jorisvandenbossche
Copy link
Member

Good point, we should update our importing of pyproj and provide a better error message if it is not available.

@jorisvandenbossche
Copy link
Member

Although #452 already updates the one place where we import pyproj?

@theroggy
Copy link
Member Author

Yes, after making this issue I noticed it was easy to just remove the import...

@theroggy
Copy link
Member Author

theroggy commented Jul 27, 2024

Back to the drawing board... I added pyproj previously to the environment file to focus the test on the switch to libgdal-core and hadn't removed it yet. Now I removed it again in #452 quite some tests are failing because pyproj not being available leads to different behaviour in geopandas...

What is the way forward? Add pyproj as a dependency in the conda package or try further to get the tests running without pyproj?

@martinfleis
Copy link
Member

When we allowed geopandas without pyproj, we had to change quite a lot of tests as the expected value for CRS changes to None.

If we want to properly do it here, we might need to follow the same model.

We should allow pyogrio without pyproj to support this model in geopandas so I wouldn't add it necessarily as a conda dependency.

@theroggy
Copy link
Member Author

theroggy commented Jul 27, 2024

It should be OK now in #452: no more failing tests when pyproj is not available...

@theroggy theroggy self-assigned this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants