Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datahub: Tms support for basemap #1073

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Datahub: Tms support for basemap #1073

merged 2 commits into from
Jan 8, 2025

Conversation

AlitaBernachot
Copy link
Collaborator

@AlitaBernachot AlitaBernachot commented Jan 6, 2025

Description

This PR adds TMS configuration support for basemap layer in the map preview.

[[map_layer]]
type = "maplibre-style"
styleUrl = "https://data.geopf.fr/annexes/ressources/vectorTiles/styles/PLAN.IGN/gris.json"
accessToken = "mytoken" #optional

Architectural changes

none

Screenshots

no UI evolution

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Affected libs: util-app-config, feature-map, feature-record, feature-router,
Affected apps: metadata-editor, datahub, demo, webcomponents, map-viewer, search,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Jan 6, 2025

📷 Screenshots are here!

@coveralls
Copy link

coveralls commented Jan 6, 2025

Coverage Status

coverage: 85.71% (+1.5%) from 84.201%
when pulling 4f88923 on GSIGNGPF-27-tms
into 16f1367 on main.

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, thanks! welcome to the contributors @AlitaBernachot 🙂

@AlitaBernachot AlitaBernachot merged commit 17894ab into main Jan 8, 2025
14 checks passed
@AlitaBernachot AlitaBernachot deleted the GSIGNGPF-27-tms branch January 8, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants