[Editor]: Change title input to handle multiline #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Affected libs:
|
|
📷 Screenshots are here! |
cmoinier
force-pushed
the
ME-title-multiline
branch
from
7d53456 to
1ca084b
Compare
Angi-Kinas
requested changes
Nov 18, 2024
There was a problem hiding this comment.
Thank you @cmoinier for adding this multiline feature!
Could you have another look at this? I think it is not yet working as expected. The icon for editing the title is no longer working.
Thanks!
libs/feature/editor/src/lib/components/record-form/form-field/form-field.component.ts
Show resolved
Hide resolved
cmoinier
force-pushed
the
ME-title-multiline
branch
from
789581f to
b073f6a
Compare
Angi-Kinas
reviewed
Nov 18, 2024
There was a problem hiding this comment.
There are some little things to clean up before merging.
I'll test it again tomorrow. Thank you @cmoinier !
libs/feature/editor/src/lib/components/record-form/form-field/form-field.component.ts
Outdated
Show resolved
Hide resolved
libs/feature/editor/src/lib/components/record-form/form-field/form-field.component.html
Outdated
Show resolved
Hide resolved
libs/feature/editor/src/lib/components/record-form/form-field/form-field.component.ts
Angi-Kinas
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Thank you for the cleanup @cmoinier !
The PR looks good to go 🚀
Sorry for the delay!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the title input of the editor to a textarea that can handle multilines, for consultation and editing.
Screenshots
Quality Assurance Checklist
breaking changelabelbackport <release branch>label