diff --git a/apps/datahub-e2e/src/e2e/datasetDetailPage.cy.ts b/apps/datahub-e2e/src/e2e/datasetDetailPage.cy.ts index afb06fc3a4..362fc728b5 100644 --- a/apps/datahub-e2e/src/e2e/datasetDetailPage.cy.ts +++ b/apps/datahub-e2e/src/e2e/datasetDetailPage.cy.ts @@ -97,12 +97,7 @@ describe('dataset pages', () => { it('should display the description', () => { cy.get('datahub-record-metadata') .find('[id="about"]') - .find('gn-ui-metadata-info') - .find('gn-ui-content-ghost') - .find('gn-ui-max-lines') - .children('div') - .children('div') - .children('p') + .find('gn-ui-markdown-parser') .should(($element) => { const text = $element.text().trim() expect(text).not.to.equal('') @@ -133,18 +128,6 @@ describe('dataset pages', () => { expect(text).not.to.equal('') }) }) - it('should display the keywords', () => { - cy.get('datahub-record-metadata') - .find('[id="about"]') - .find('gn-ui-metadata-info') - .find('gn-ui-content-ghost') - .find('gn-ui-max-lines') - .children('div') - .children('div') - .children('div') - .children('gn-ui-badge') - .should('have.length.gt', 0) - }) it('should display the lineage and usage tabs', () => { cy.get('datahub-record-metadata') .find('[id="about"]') @@ -177,31 +160,6 @@ describe('dataset pages', () => { cy.get('[data-cy="organization-name"]').click() cy.url().should('include', '/search?publisher=') }) - it('should go to dataset search page when clicking on keyword and filter by keyword', () => { - cy.get('datahub-record-metadata') - .find('[id="about"]') - .find('gn-ui-metadata-info') - .find('gn-ui-content-ghost') - .find('gn-ui-max-lines') - .children('div') - .contains('Read more') - .click() - - cy.get('datahub-record-metadata') - .find('gn-ui-badge') - .children('div') - .first() - .as('keyword') - - cy.get('@keyword').then((key) => { - keyword = key.text().toUpperCase() - cy.get('@keyword').first().click() - cy.url().should('include', '/search?q=') - cy.get('gn-ui-fuzzy-search') - .find('input') - .should('have.value', keyword) - }) - }) }) }) diff --git a/apps/datahub/src/app/record/record-metadata/record-metadata.component.html b/apps/datahub/src/app/record/record-metadata/record-metadata.component.html index c07d56fccc..625eb0b34c 100644 --- a/apps/datahub/src/app/record/record-metadata/record-metadata.component.html +++ b/apps/datahub/src/app/record/record-metadata/record-metadata.component.html @@ -19,7 +19,6 @@ class="sm:block" [metadata]="facade.metadata$ | async" [incomplete]="facade.isIncomplete$ | async" - (keyword)="onInfoKeywordClick($event)" > diff --git a/libs/ui/elements/src/lib/metadata-info/metadata-info.component.html b/libs/ui/elements/src/lib/metadata-info/metadata-info.component.html index fa13aae0ba..2a4ed6877a 100644 --- a/libs/ui/elements/src/lib/metadata-info/metadata-info.component.html +++ b/libs/ui/elements/src/lib/metadata-info/metadata-info.component.html @@ -1,9 +1,3 @@ -

- record.metadata.about -

@@ -11,20 +5,6 @@ - -

- record.metadata.keywords -

-
- {{ keyword }} -
-
diff --git a/libs/ui/elements/src/lib/metadata-info/metadata-info.component.spec.ts b/libs/ui/elements/src/lib/metadata-info/metadata-info.component.spec.ts index a1800f59e0..a8d302391c 100644 --- a/libs/ui/elements/src/lib/metadata-info/metadata-info.component.spec.ts +++ b/libs/ui/elements/src/lib/metadata-info/metadata-info.component.spec.ts @@ -73,17 +73,10 @@ describe('MetadataInfoComponent', () => { const displayedElement = fixture.nativeElement.querySelector('.noUsage') expect(displayedElement).toBeFalsy() }) - it('should display the keywords section', () => { - // Use waitForAsync to handle asynchronous changes in the DOM. - fixture.whenStable().then(() => { - const displayedElement = - fixture.nativeElement.querySelector('ng-container') - expect(displayedElement).toBeTruthy() - }) - }) it('should display the abstract section', () => { - const displayedElement = - fixture.nativeElement.querySelector('.md-description p') + const displayedElement = fixture.nativeElement.querySelector( + 'gn-ui-markdown-parser' + ) expect(displayedElement).toBeTruthy() }) it('should display the metadata origin even if there is no lineage text', () => { diff --git a/libs/ui/elements/src/lib/metadata-info/metadata-info.component.ts b/libs/ui/elements/src/lib/metadata-info/metadata-info.component.ts index b489a1913e..c2745049c2 100644 --- a/libs/ui/elements/src/lib/metadata-info/metadata-info.component.ts +++ b/libs/ui/elements/src/lib/metadata-info/metadata-info.component.ts @@ -52,8 +52,4 @@ export class MetadataInfoComponent { fieldReady(propName: string) { return !this.incomplete || propName in this.metadata } - - onKeywordClick(keyword: string) { - this.keyword.emit(keyword) - } }