-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto-create required function files #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffrich
commented
Oct 30, 2022
This was
linked to
issues
Oct 30, 2022
Not sure why this broke, but the test input isn't taking on CI. Focusing the input first fixes it.
Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-desert-00b80111e-92.westus2.2.azurestaticapps.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the setup needed to use the adapter.
/api/render
folder with some custom files in it.apiDir
option to instruct the adapter to output the SvelteKit render function into a directory with the rest of your functionsThis is a breaking change, but migration should be straightforward for most. See below for a migration guide. For a full working setup, see the
demo
folder in this repo.Fix for #70. Also implements #42.
Migration guide
If you do not have additional custom Azure functions in the
/api
directory (the majority of users):/api
directory./api/render
entry from your.gitignore
/.github/workflows/azure-static-web-apps-*.yml
) to usebuild/server
for theapi_location
. The adapter now outputs the built function into thebuild
directory.If you do have additional custom Azure functions in the
/api
directory:.gitignore
to ignore the new SvelteKit function directory,api/sk_render
. Previously, this wasapi/render
api/render
folder. This no longer needs to be present in the repo at build time.sk_render
to this directory that contains the Azure function for rendering.If you have questions about the migration, please open an issue on this repo.