Code suggestions

[falkamelung]

Some comments on function call:

rain_plotter('bar', volcanos, rainfall, quantiles, rolling_number, scale, eruptions, elninos, lat_range, lon_range, by_season)

• use plot_type='bar'
• instead of volcanoes maybe sites_dict
• instead of scale use log_flag=True
• rename eruptions tovoclanic_events
• are lat_range, lon_range needed?
• by_season can be converted to a flag? The default is to use the full period and seasonal_flag=False.

helper_functions.py: Maybe separate in multiple scripts: plot_functions.py, el_nino_functions.py, helper_functions.py

• plotting: try to do all the matplotlib settings in a separate function (configure_plot_settings.py) as much as possible.

• we also want to create ax and fig in a separate function. If you have an idea on how to do this please do so. Else we will do this later.

• We eventually want to separate notebooks from python scripts, i.e. the python scripts will end up in the precip repo. But I will ask Giacomo to do this once he puts all this together to a proper package.