-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website errors for Chapters 5-8 #246
Comments
Thanks! I guess that there is an error in the code of Chapter 5 on GitHub actions. Locally it works fine for me. Where can we see the errors log of the Python code in GitHub actions to figure out what's different there? 🙏 |
|
@michaeldorman you can find this error by clicking on "Render" at https://github.com/geocompx/geocompy/actions/runs/10767927445/job/29856118003 and then scrolling down. |
Probably a Python package version issue, although surprised it didn't result in Actions failing. Also affects other the gh-pages workflow: https://github.com/geocompx/geocompy/actions/runs/10767927441/job/29856117885#step:4:413 |
Logical next step would be to test locally with the python image: geocompy/.github/workflows/netlify.yml Line 10 in 4f124ea
Also in our devcontainer: Line 2 in 4f124ea
|
Testing in GitHub codespaces which uses the image listed above. Anyone can do by clicking this link, I think: https://github.com/codespaces/new?hide_repo_select=true&ref=main&repo=447558863 |
Failing command: Line 449 in 4f124ea
|
Removing
Fixes it. Will put in PR. |
I think it's numpy2 related:
Can you try installing NumPy 2.0 @michaeldorman ? |
In the container we have 2.0.1:
|
Yes, there are lots of issues: https://github.com/search?q=repo%3Arasterio%2Frasterio+numpy&type=issues Notably this one by @sgillies: rasterio/rasterio#2819 Should we upgrade to 1.4.0 when ready? |
Currently we're on 1.3: Line 11 in 4f124ea
|
Got it, thanks @Nowosad ! |
Any comments on this very welcome @sgillies and great to see 1.4.0rc1 is due out today! Do you have an ETA for 1.4.0, without the rc (release candidate I think) bit? |
Thanks @Robinlovelace 🙏 |
Could be good idea from above. |
Interesting... I tried installing |
You need to upgrade a load of pkgs I think Michael. The Docker container has the following, as you'd be able to find out with
|
Thanks @Robinlovelace , seems to be solved. I also needed |
Solved, thanks @Nowosad and @Robinlovelace ! The issue was using out_image, out_transform = rasterio.mask.mask(
src_nlcd,
zion.geometry.to_crs(src_nlcd.crs),
crop=False,
nodata=src_nlcd.nodata
) |
Hi there,
I cannot see Chapters 5-8. I get the following error.
The text was updated successfully, but these errors were encountered: