-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve our Docker game #188
Comments
@Robinlovelace For Dev Containers you should build on my/b-data's language docker stacks. That is what I/b-data is using for the [CUDA-enabled] Data Science Dev Containers. E.g. Python scipy: devcontainer.json, Python.Dockerfile |
But I think R qgisprocess is the one you are looking for: devcontainer.json, R.Dockerfile. |
OK to chat over this at some point @benz0li ? I sense a few minutes of chat could save many minutes if not hours of faff 🙏 |
You can test the Data Science Dev Containers with GitHub Codespaces at https://github.com/b-data/data-science-devcontainers. (New with options...) |
@Robinlovelace Yes, of course. See my GitHub profile for my email address. |
Cross references: |
Great stuff Olivier. Looking forward to talking next week. |
One option: use 'slim' version to reduce size. |
From
|
Results in an image that's around 600 MB bigger... |
|
Good news on this, thanks to mini pair programming session with @benz0li, the main Python image is ~30% smaller than it was, previously 900MB, this is impressive given the number of pkgs in there, thanks for the tip about using the slim images Olivier! There are other improvements we can make, including making all images start from the same base, for R and Python, we can continue the conversation here: geocompx/docker#40 I think I'm happy with the updated
image but will leave this issue open for now in case there are any other quick wins. |
I think this can be closed for now. If anyone knows of any other quick wins let us know. Thanks @benz0li for speeding up our Docker game! |
Currently we use
geocompy/.devcontainer.json
Line 2 in 2f0c38a
in the devcontainer
geocompy/.github/workflows/pr.yml
Line 8 in 2f0c38a
in the workflow
These are not optimal in some ways, as already pointed out in other issues.
With apologies for out-of-the blue tagging @benz0li, is this something you could advise us on? Two options that jump to mind are:
I'm thinking the great images you created, especially https://github.com/b-data/jupyterlab-python-docker-stack look really good in this space, happy to contribute upstream + to collaborate.
The text was updated successfully, but these errors were encountered: