Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 4.1 Missing argument 2 for Geocoder\Provider\CloudMadeProvider::__construct() #5

Closed
leigeber opened this issue Dec 21, 2013 · 10 comments

Comments

@leigeber
Copy link

Get the error below. I am not seeing where the API key is supposed to be set that should be getting to the CloudMade provider. Am I doing something wrong here? Thanks.

Missing argument 2 for Geocoder\Provider\CloudMadeProvider::__construct(), called in /var/www/vendor/toin0u/geocoder-laravel/src/Toin0u/Geocoder/GeocoderServiceProvider.php on line 57 and defined
@toin0u
Copy link
Member

toin0u commented Dec 21, 2013

Hi Michael,

I've got an email with exactly the same question. Atm the lib doest not support this. It you want to fix it asap - I suggest you to extend the service provider.

I'm thinking about the best way to implement this. It's not just a parameter in the onfiguration file beacuse providers are differents.

@leigeber
Copy link
Author

Gotcha, thanks for the quick response. We'll do just that.

@willdurand
Copy link
Member

Can we do something to get this issue "solved" or "closed"?

@toin0u
Copy link
Member

toin0u commented Jan 16, 2014

Mmm I'll prepare a patch for that becase we should be able to give som arguments to provider's constructor via the config file. I think it will make it easier to use.

@anaxamaxan
Copy link
Contributor

I'm working on an update for this, to include correct config for every supported provider.

@toin0u
Copy link
Member

toin0u commented Feb 1, 2014

Thanks 👍 It sounds great :)

@toin0u
Copy link
Member

toin0u commented Feb 13, 2014

ping @anaxamaxan :)

@Forbin
Copy link

Forbin commented Feb 13, 2014

I just got this error as well.

@willdurand
Copy link
Member

nice!

@toin0u
Copy link
Member

toin0u commented May 13, 2014

🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants