Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PC表示の幅(max-width)を増やす #269

Closed
gentksb opened this issue Feb 22, 2023 · 1 comment · Fixed by #325
Closed

PC表示の幅(max-width)を増やす #269

gentksb opened this issue Feb 22, 2023 · 1 comment · Fixed by #325
Labels
UI enhancement UI improvement

Comments

@gentksb
Copy link
Owner

gentksb commented Feb 22, 2023

why

サイドの空白が大きい。Google Adsenseの自動広告がサイドバー相当の場所に挿入されるため、真ん中付近に挿入されたとき視線が誘導されてしまう

考慮

1行が長すぎると読みにくくなるため、1行当たりの文字数を考慮すること

sample

メルカリエンジニアリングブログ
https://engineering.mercari.com/blog/entry/20230221-mercari-intern/
→コンテンツエリアは広いものの、Paddingをうまく使って1行の文字数を減らしている
@gentksb gentksb added Enhancement New feature or request UI enhancement UI improvement labels Feb 22, 2023
@gentksb gentksb removed the Enhancement New feature or request label Sep 14, 2023
@gentksb
Copy link
Owner Author

gentksb commented Oct 14, 2023

実装済み

@gentksb gentksb closed this as completed Oct 14, 2023
@gentksb gentksb linked a pull request Oct 15, 2023 that will close this issue
[Migration]Cloudflare and astro #325
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UI enhancement UI improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Migration]Cloudflare and astro gentksb/blog
1 participant
@gentksb