Setuptools fix #591
Merged
Setuptools fix #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #591 +/- ##
=======================================
Coverage 88.79% 88.79%
=======================================
Files 76 76
Lines 12428 12428
=======================================
Hits 11036 11036
Misses 1392 1392 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, massive thanks to @erolm-a for this one! The problem was that the standard setuptools build step collects python modules to include before building extensions which is bad because SWIG generates python modules as part of building extensions! This solves this by simply re-ordering the sub-commands within the setuptools build command. I have fixed this for GeNN 5 by getting rid of SWIG but GeNN 4 seems to be malingering so this is very helpful!
Fixes #590
Fixed #310