Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed potential bug where RNG isn't instantiated #540

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

neworderofjamie
Copy link
Contributor

If custom update variables were the only place in a model where an RNG was required for initialization, this wouldn't be detected and the model wouldn't compile. Have added extra unit tests and beefed up existing ones to test further up.

@neworderofjamie neworderofjamie added this to the GeNN 4.8.0 milestone Oct 12, 2022
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 89.38% // Head: 89.34% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (e6d85fb) compared to base (5b14794).
Patch coverage: 55.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #540      +/-   ##
==========================================
- Coverage   89.38%   89.34%   -0.04%     
==========================================
  Files          73       73              
  Lines       10747    10767      +20     
==========================================
+ Hits         9606     9620      +14     
- Misses       1141     1147       +6     
Impacted Files Coverage Δ
src/genn/genn/code_generator/backendSIMT.cc 89.21% <50.00%> (-0.47%) ⬇️
src/genn/backends/single_threaded_cpu/backend.cc 90.80% <60.00%> (-0.35%) ⬇️
src/genn/genn/customUpdate.cc 93.54% <0.00%> (+2.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@tnowotny tnowotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible - nice catch.
Somehow I am having a deja-vu of having reviewed this one before but apparently not.

@neworderofjamie neworderofjamie merged commit 6de3b70 into master Oct 24, 2022
@neworderofjamie neworderofjamie deleted the init_rng_tests branch October 24, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants