Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly expose postsynaptic model extra global parameters to PyGeNN #522

Merged
merged 6 commits into from
May 23, 2022

Conversation

neworderofjamie
Copy link
Contributor

@neworderofjamie neworderofjamie commented May 16, 2022

Initially I thought more stuff could be broken so I added further tests but, turns out, there was simple a missing argument in the PyGeNN function to create custom postsynaptic models.

Fixes #514

@neworderofjamie neworderofjamie added this to the GeNN 4.7.2 milestone May 16, 2022
@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #522 (5e3cf5f) into master (93a50ca) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #522      +/-   ##
==========================================
+ Coverage   86.96%   87.05%   +0.08%     
==========================================
  Files          84       84              
  Lines       18089    18090       +1     
==========================================
+ Hits        15731    15748      +17     
+ Misses       2358     2342      -16     
Impacted Files Coverage Δ
include/genn/genn/postsynapticModels.h 100.00% <0.00%> (ø)
src/genn/genn/code_generator/groupMerged.cc 89.25% <0.00%> (+0.48%) ⬆️
src/genn/genn/code_generator/generateRunner.cc 96.53% <0.00%> (+0.53%) ⬆️
include/genn/genn/synapseGroup.h 92.45% <0.00%> (+1.88%) ⬆️
include/genn/genn/currentSource.h 88.88% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93a50ca...5e3cf5f. Read the comment docs.

@neworderofjamie neworderofjamie marked this pull request as ready for review May 16, 2022 17:45
@neworderofjamie neworderofjamie requested a review from tnowotny May 16, 2022 17:46
@neworderofjamie neworderofjamie modified the milestones: GeNN 4.7.2, GeNN 4.8.0 May 19, 2022
Copy link
Member

@tnowotny tnowotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duh ... good catch.

@neworderofjamie neworderofjamie merged commit 885ba39 into master May 23, 2022
@neworderofjamie neworderofjamie deleted the fix_psm_egp branch May 23, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra global parameters are half-implemented for Postsynaptic models
2 participants