Automatically find Visual Studio #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use distutils to find msbuild within MSVC environment
Codecov Report
@@ Coverage Diff @@
## master #471 +/- ##
==========================================
- Coverage 87.03% 87.03% -0.01%
==========================================
Files 84 84
Lines 18099 18099
==========================================
- Hits 15753 15752 -1
- Misses 2346 2347 +1
Continue to review full report at Codecov.
|
|
Further testing suggests this isn't enough as cl.exe needs to be in the path if GeNN decides to do some block-size optimization |
* no point in doing this for each ``GeNNModel`` - makes sense to have this module-scope * need to add MSVC stuff to ``os.environ`` so it works with code generator (in process) as well as msbuild (child process)
|
Tested on:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs two pieces of nastiness:
setuptoolsto configure MSVC environment (same as Brian2)distutilsto find msbuild within MSVC environment (due to weirdness of whatever APIsubprocess.check_calluses underneath)This means you can use PyGeNN from a standard Python prompt e.g. an Anaconda prompt.
Fixes #466