Missing include breaks compilation on Visual C++ 2017 #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #462 +/- ##
=======================================
Coverage 87.25% 87.25%
=======================================
Files 78 78
Lines 17056 17056
=======================================
Hits 14883 14883
Misses 2173 2173
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hadn't tested on Visual C++ 2017 for a while and, as is always the way, standard library header files are subtly different so an additional include was required. Once Alicia has finished with it I think I might get Paul to reformat my old machine for Windows CI - at one point Stefan had a Windows machine but I think he had a traditional mid-PhD Linux-conversion.