Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that 64-bit compiler is used on Windows #407

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

neworderofjamie
Copy link
Contributor

For reasons best known to itself, without explicitly preferring a 64-bit toolchain, MSBuild was using a 32-bit version of the 64-bit compiler (if that makes sense) with resulting 4GB memory limit. This prevented very large models like the multi-area model compiling.

@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #407 (5733f46) into master (3b3d3ff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #407   +/-   ##
=======================================
  Coverage   86.76%   86.76%           
=======================================
  Files          71       71           
  Lines       13242    13242           
=======================================
  Hits        11490    11490           
  Misses       1752     1752           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b3d3ff...5733f46. Read the comment docs.

Copy link
Member

@tnowotny tnowotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep ... the wisdom of the Windows toolchain is unmatched.

@neworderofjamie neworderofjamie merged commit eac6dd8 into master Mar 26, 2021
@neworderofjamie neworderofjamie deleted the visual_studio_64_bit branch March 26, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants