Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyGeNN doesn't correctly handle neuron variables with delay slots #393

Closed
neworderofjamie opened this issue Jan 20, 2021 · 0 comments · Fixed by #602
Closed

PyGeNN doesn't correctly handle neuron variables with delay slots #393

neworderofjamie opened this issue Jan 20, 2021 · 0 comments · Fixed by #602

Comments

@neworderofjamie
Copy link
Contributor

Group._load_vars assumes no delays, this is bad. The variable views should be made multi-dimensional exposing the delay slots directly. This will break existing code in a reasonably intuitive way and we can add a helper property to automatically pull out the correct slice based on the spike queue pointer.

@neworderofjamie neworderofjamie added this to the GeNN 4.5.0 milestone Jan 20, 2021
@neworderofjamie neworderofjamie removed this from the GeNN 4.5.0 milestone Jul 15, 2021
@neworderofjamie neworderofjamie linked a pull request Jan 3, 2024 that will close this issue
@neworderofjamie neworderofjamie added this to the GeNN 5.0.0 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant