Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assign_external_pointer overrides should use explicitly sized integer types #288

Closed
neworderofjamie opened this issue Jan 3, 2020 · 1 comment

Comments

@neworderofjamie
Copy link
Contributor

neworderofjamie commented Jan 3, 2020

These are generated here:

https://github.com/genn-team/genn/blob/master/generate_swig_interfaces.py#L287-L292

But using unsized types makes numpy interfacing code irritating specifically as sizeof(long) is different on Windows and Linux. Correct solution would be using uint32_t etc. These would then need to be used here:

https://github.com/genn-team/genn/blob/master/pygenn/genn_model.py#L156-L172

@neworderofjamie
Copy link
Contributor Author

Everything now uses sized types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant