-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the possibility to load a configuration instead of init parameters #98
Comments
Thanks @NP4567-dev for drafting this issue, I'll add some bits on what I imagined as well!
Example of what it could look like ( [ecologits]
region="WOR" # Can be removed, as it is the default value can be named `zone` as well, or something else...
providers=[
"openai",
"anthropic", # Active, but no custom config
"mistralai",
"scaleway" # Not supported right now, just to give an example with a cloud provide
]
[ecologits.openai]
region="USA" # Location set to the US, we will select according values for eletricity mix, off-site water consumption...
[ecologits.mistralai]
region="FRA" # Location set to France, we will select according values for eletricity mix, off-site water consumption...
[ecologits.scaleway]
region="fr-par" # This parameter could also accept cloud regions
pue=1.18 # Known PUE and WUE of the specific data center
wue=0.4
wue_offsite=3.2 # Off-site WUE also changed to a custom value We can add more specific parameters to precisely customize the methodology regarding electricity mix, embodied impacts of hardware and more. But, let's do it step-by-step with simple and useful things first! |
Many thanks for the draft @NP4567-dev ! @samuelrince Totally agree about the custom models. Let's maybe avoid any connection to an external network if not needed To me the |
The last part with "Other remarks" was about things that are not part of this feature and will be tackled in other issue later, sorry if that was not clear enough. I definitely agree with going steps by steps. I think the ability to edit parameters as you suggested @adrienbanse could be kept in an other separated issue for later ? Or maybe developing the other parts will naturally enable this? For now I propose the following acceptance criteria for this feature:
Please update them as you see fit or just 👍 this and I can get started on this 😄 |
Description
Context:
In this first issue on the topic, the aim is to enable the user to provide a configuration for both existing parameters (providers and electricity_mix_zone).
The addition of other configuration parameters, while taken into account will be addressed in other issues
It is important to stay compatible with older versions while guaranteeing enough flexibility to implement future configuration features.
Changes:
Add the configuration argument. It is a path pointing to a locally stored yaml configuration in Ecologits.init().
The file could have the following formatting for now:
I see three possible ways to handle it:
These questions have to be answered before proceeding:
Other remarks:
Not in this feature but could be added later:
Feel free to correct or add anything 😃
The text was updated successfully, but these errors were encountered: