fix: don't add error snippets on screenshot error #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sipayRT
approved these changes
Jun 27, 2024
src/error-snippets/index.ts
Outdated
| @@ -14,7 +14,7 @@ const stackFrameLocationResolver = async (stackFrame: SufficientStackFrame): Pro | |||
| }; | |||
|
|
|||
| export const extendWithCodeSnippet = async (err: WithSnippetError): Promise<WithSnippetError> => { | |||
| if (!err) { | |||
| if (!err || shouldNotAddCodeSnippet(err)) { | |||
There was a problem hiding this comment.
we can pass error to the shouldNotAddCodeSnippet function and then check all cases inside of the function
KuznetsovRoman
force-pushed
the
TESTPLANE-107.snippet_scr
branch
from
7b300e0 to
82b2546
Compare
KuznetsovRoman
force-pushed
the
TESTPLANE-107.snippet_scr
branch
from
82b2546 to
a5d7842
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.