fix: correctly switch between iframes on disable animation #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudaGod
commented
Dec 26, 2023
| @@ -305,12 +305,12 @@ module.exports = class ExistingBrowser extends Browser { | |||
| for (const iframe of iframes) { | |||
There was a problem hiding this comment.
Проблема возникала когда на странице оказывалось 2 айфрейма. После перехода в первый и выполнения отключения анимации осуществлялся сразу же переход в следующий. При этом контекст оставался в предыдущем фрейме. В итоге летела не очень понятная ошибка: stale element reference: element is not attached to the page document.
В итоге теперь после отключения анимации в одном из айфреймов сразу же возвращаюсь в родителя. За счет этого проблема больше не воспроизводится.
| // switchToParentFrame does not work in ios - https://github.com/appium/appium/issues/14882 | ||
| await this._session.switchToFrame(null); | ||
| } | ||
| } catch (e) { |
There was a problem hiding this comment.
Вместо finally теперь свитч в родителя выполняю в catch
DudaGod
force-pushed
the
HERMIONE-1305.fix_stale_element_ref
branch
from
e21a0e4 to
eabea08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.