Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Cargo.toml with profile overrides (by using newer version of cargo) #94

Closed
wants to merge 2 commits into from

Conversation

evan-dickinson
Copy link

Cargo version 1.41 stabilized profile overrides. But cargo-geiger still considered the feature unstable. Running geiger on a crate that uses profile overrides was failing with this error:

error: failed to parse manifest at `Cargo.toml`

Caused by:
  feature `profile-overrides` is required

this Cargo does not support nightly features, but if you
switch to nightly channel you can add
`cargo-features = ["profile-overrides"]` to enable this feature

To fix the problem, I incremented the version of cargo to 0.42.0. And I also ran cargo update to update other dependencies, too.

@evan-dickinson
Copy link
Author

I'm not sure why the CI tests failed. I did cargo test --all and it succeeded on my computer (macOS 10.14).

@anderejd
Copy link
Contributor

Thanks for the PR.

It seems like the master branch is failing the tests as well on Azure now. Will look into it later this week.

@anderejd
Copy link
Contributor

anderejd commented Mar 12, 2020

The new test snapshot files seems to have a different naming than the existing ones...

@anderejd
Copy link
Contributor

Let's roll with the new naming of the test snapshots. Feel free to delete the old snapshots and commit new ones if they look correct.

@anderejd
Copy link
Contributor

anderejd commented Apr 7, 2020

Superseded by #98.

@anderejd anderejd closed this Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants