NOISSUE - Clean up error handling, remove unwrap() calls, logging #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meaningful messages
|
Sorry for the delay, it seems I missed the notification. I would like add you as maintainer if you are interested? @tarcieri would also need to approve. I'll review this PR now. |
anderejd
reviewed
Feb 12, 2021
Comment on lines
-35
to
-46
| pub trait GetPackageNameFromCargoMetadataPackageId { | ||
| fn get_package_name_from_cargo_metadata_package_id( | ||
| pub trait GetPackageNameAndVersionFromCargoMetadataPackageId { | ||
| fn get_package_name_and_version_from_cargo_metadata_package_id( | ||
| &self, | ||
| package_id: &cargo_metadata::PackageId, | ||
| ) -> Option<String>; | ||
| } | ||
|
|
||
| pub trait GetPackageVersionFromCargoMetadataPackageId { | ||
| fn get_package_version_from_cargo_metadata_package_id( | ||
| &self, | ||
| package_id: &cargo_metadata::PackageId, | ||
| ) -> Option<cargo_metadata::Version>; |
|
The new error messages look great! |
|
Hi @anderejd, I'd definitely be keen to be added as a maintainer! |
|
@tarcieri Since this project now exists under rust-secure-code it seems reasonable to me to have you on board with adding another maintainer. Your thoughts? |
|
@tarcieri Ping |
|
@jmcconnell26 Invite has been sent! |
|
Awesome, accepted it now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
meaningful messages