Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Birch community calendar is showing "empty slot" in event titles #2094

Closed
katjam opened this issue Oct 16, 2023 · 15 comments
Closed

[Bug]: Birch community calendar is showing "empty slot" in event titles #2094

katjam opened this issue Oct 16, 2023 · 15 comments
Assignees
Labels
bug Release Drafter category - bug impacting the normal functioning of existing features requires support call

Comments

@katjam
Copy link
Member

katjam commented Oct 16, 2023

Description

Events pulling through from Birch Community calendar are showing as empty slots. We suspect this needs to be fixed by fixing the data their end.

Steps to reproduce

  1. Visit https://manchester.placecal.org/partners/the-birch-community-centre

Example image

image

@katjam katjam added bug Release Drafter category - bug impacting the normal functioning of existing features needs triage labels Oct 16, 2023
@katjam
Copy link
Member Author

katjam commented Oct 16, 2023

Kim's suggestion tl;dr
Arrange a 30 min call to establish their situation and then make recommendation of how they can improve the feed.

in this case, i think its that the source feed is bad. so we need to have a case study of where we are to date and then a next action for us/them to go through. its the flowchart thing right. maybe a rule of thumb is we want to go as close to the source as possible at all times
i think fundamentally they just dont quite understand what the feeds are and where theyc ome from and dont know how to ask to get to that. maybe its good to get on a call and step through the exact combos of plugins and stuff and what guides they followed and get that documented as a case study.
i think theres a google cal feed powering the site and the wordpress plugin is making its own feed
i think our ideal sitch would be to be using the Google feed directly
but it may also be they just need some help with that e.g. putting bookings on antoher cal
i deffo dont think its anything placecal needs to change
another option would be - maybe what if the widget theyre using is shit and what theyd really like is to make an ical feed that goes into placecal and then we have a palcecal embed widget
i think we just need to write up what these routes are as a first step
does that help
so maybe we need to commit to say - 10 x 30 min calls directly with partners as needed where the PHT team cant fix it themselves. but come out of each of those with something new that the PHT team can follow
if we can get a testimonial or photo or some notes about what problem theyre tryign to solve at the same time - brilliant
if we can get some of the dev team to do these calls - even better

@kimadactyl
Copy link
Member

kimadactyl commented Oct 23, 2023

Adding to current milestone to find some kind of resolution to as this is litearlly preventing onboarding i think

@kimadactyl
Copy link
Member

Or let me me more specific: we need to decide what to do in this use case where a calendar feed is provided with bad data in

@aaaaargZombies
Copy link
Contributor

todo

  • investigate what data is being produced by the feed
  • discuss with user
  • is there obvious errors we can filter for or warn partners about automatically?

@aaaaargZombies aaaaargZombies self-assigned this Oct 30, 2023
@aaaaargZombies
Copy link
Contributor

a bit of browsing of their site suggests this is an error on their end

https://www.birchcommunitycentre.co.uk/events/page/19/

image

Next I'll look at the actual feed and see if there's obvious errors we can filter for.

@aaaaargZombies
Copy link
Contributor

It looks like a totally valid .ics feed to me, no missing fields that we should obviously filter for.

BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//wp-events-plugin.com//6.3//EN
TZID:Europe/London
X-WR-TIMEZONE:Europe/London
BEGIN:VEVENT
UID:[email protected]
DTSTART;TZID=Europe/London:20231030T093000
DTEND;TZID=Europe/London:20231030T173000
DTSTAMP:20231013T160657Z
URL:https://www.birchcommunitycentre.co.uk/events/empty-slot-28/
SUMMARY:Empty slot
DESCRIPTION:Empty slot (auto created).
CATEGORIES:Open
LOCATION:#_LOCATIONNAME\, #_LOCATIONFULLLINE\, #_LOCATIONCOUNTRY
X-APPLE-STRUCTURED-LOCATION;VALUE=URI;X-ADDRESS=#_LOCATIONFULLLINE\, #_LOCA
 TIONCOUNTRY;X-APPLE-RADIUS=100;X-TITLE=#_LOCATIONNAME:geo:0,0
END:VEVENT

@aaaaargZombies
Copy link
Contributor

aaaaargZombies commented Oct 30, 2023

The are using this to generate the calendar/ feed https://wp-events-plugin.com/

It looks like there is an option to produce a filtered iCal url but this requires a paid add on

https://wp-events-plugin.com/documentation/importing-exporting/export-setup/

Events Manager I/O is our Importer / Exporter add-on, currently available as a separate add-on available to Pro users.


I guess the question we would have to have ask them is

  • why are they automatically creating these empty slot events, is it an important part of their booking process etc.
  • If it's not important can we disable them
  • if it is important is there an alternative way to get at the events? We probably don't want to ask them to maintain two calendars but looking at the email it sounds like the plugin is drawing from a google feed anyway so perhaps we can also use that

@aaaaargZombies
Copy link
Contributor

Looking at some discrepancies between the calendar we import from and whats on their own site

@katjam katjam assigned katjam and unassigned aaaaargZombies Nov 8, 2023
@katjam
Copy link
Member Author

katjam commented Nov 8, 2023

Ivan and I had a call with their WP developer and they should be able to fix their end.

  • He has already had to modify the plugin
  • They use it for their events and booking form and filter the content in those places accordingly
  • The empty slots are the ones available in their booking form for the available booking of the hall.
  • The events are generated when the slots are filled
  • There is no google calendar backing this data
  • They use google caledar for personal stuff, stuff that is provisional and sometimes contains PID so it's not for public
  • The iCal feed is generated by the plugin.
  • They do not use the iCal feed but as @aaaaargZombies discovered - it is viewable on a public url which will be helped by this fix also.

We helped him find the right place to alter the code that generates the iCal feed and closeing as it has been left with them. We can assume they will get back to us if they are unable to fix (we asked him to) - so this should be verifiable in a period of time / not yet determined.

@katjam katjam closed this as completed Nov 8, 2023
@r-ferrier r-ferrier added verified Issues that have been user acceptance tested won't fix and removed verified Issues that have been user acceptance tested labels Nov 9, 2023
@r-ferrier
Copy link
Contributor

I've added wontfix so that for the purposes of this release we can check that everything that needs verifying has been verified, and also technically it's something we're not addressing in the code. That being said we should check back on this in the next sprint so I've put a reminder in my calendar to re-verify this then.

@katjam
Copy link
Member Author

katjam commented Nov 20, 2023

@r-ferrier I've removed the won't fix because have had confirmation from them that they think the issue is resolved. So we can now verify and then you can tick that off your calendar!

image

@katjam katjam removed the won't fix label Nov 20, 2023
@kimadactyl
Copy link
Member

Great that you did this - for me I think the most important thing is we develop a process for what we do if this happens next time. We don't have to go to quite this length - but maybe what we would do is keep a troubleshooting list other people can follow? What do you think?

@katjam
Copy link
Member Author

katjam commented Nov 22, 2023

Great that you did this - for me I think the most important thing is we develop a process for what we do if this happens next time. We don't have to go to quite this length - but maybe what we would do is keep a troubleshooting list other people can follow? What do you think?

I think this was a very unique case, so probably docs would not be useful to anyone else.

We should, though, definitely add sweeping for issues tagged requires support call to our PlaceCal on call support role spec.

@kimadactyl
Copy link
Member

Maybe less "docs" then and more "flowchart for organisers to follow to identify if something needs to go to gfsc tech support"?

@katjam
Copy link
Member Author

katjam commented Nov 23, 2023

That's a great idea. #2146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Release Drafter category - bug impacting the normal functioning of existing features requires support call
Projects
None yet
Development

No branches or pull requests

4 participants