Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarnInstaller installs yarn 1.8 pre-release instead of yarn 1.7 stable #48

Closed
4 of 9 tasks
blushingpenguin opened this issue Jun 11, 2018 · 7 comments
Closed
4 of 9 tasks
Assignees
Labels

Comments

@blushingpenguin
Copy link

yarnInstaller installs yarn 1.8 pre-release instead of yarn 1.7 stable

Are you reporting a bug or a feature request ?

  • Bug
  • Feature request

Description

Yarn 1.8 pre-release is being installed by yarnInstaller when set to install "latest 1.x". It appears that this is due to:

https://geeklearningassets.blob.core.windows.net/yarn/tarballs.json

listing:

"v1.8.0":"https://github.com/yarnpkg/yarn/releases/download/v1.8.0/yarn-v1.8.0.tar.gz"

but:

https://github.com/yarnpkg/yarn/releases

shows it marked as pre-release. I'm unsure how the tarball is generated, but it is the reason that yarnInstaller is picking the pre-release version of yarn.

Expected behavior

yarn 1.7 should be used

System information

VSTS or TFS:

  • VSTS
  • TFS

Agent:

  • Hosted
  • Custom

OS:

  • Windows
  • Mac
  • Linux

Yarn version:
Yarn version*
1.8!

Thanks,

Mark

@haukurk
Copy link

haukurk commented Jun 11, 2018

+1

Had issues due to this as well!

@edqwerty1
Copy link

+1 builds were broken... Removing version wildcard and forcing 1.7.0 as a workaround

@k-schneider
Copy link

Got hit with this today as well. Build server started bombing every job using this task.

@sandorfr
Copy link
Member

sandorfr commented Jun 11, 2018

Thanks for reporting this. It seems there are many sub issues to this one:

  • filter out pre-releases by default (with a option to go to bleeding edge or switch to nightly Add Nightly Option #44)
  • There is a problem with 1.8.0 on VSTS.

I'm mitigating the problem by removing the 1.7.0 and disabling the job which fetches releases for now.

The 1.8.0 is worrying me a bit more. Are you using vsts feeds or npm?
Can you provide the error logs?

@sandorfr sandorfr self-assigned this Jun 11, 2018
@sandorfr sandorfr added the bug label Jun 11, 2018
@blushingpenguin
Copy link
Author

Did you mean removing 1.8? Should that ever have been in tarball.json (https://geeklearningassets.blob.core.windows.net/yarn/tarballs.json) given that it's pre-release?

I'm using VSTS, and the errors I was getting from building were simply that after "yarn install" there were missing packages.

@sandorfr
Copy link
Member

Can you provide the logs? There is probably bugs to report to yarn.

On the version it's debatable, some people want the latest prerelease because they need it. I expected people to tweak the version pattern according to their needs. It is clearly not happening. So yes I'll add the capability to choose to include prerelease (and even nightlies) in the future. The default will become what you expected.

@sandorfr
Copy link
Member

sandorfr commented Jun 16, 2018

The 2.5.0 is out and solves the prerelease issue. There’s an option to get them back if you need.

The underlying issue in yarn has been fixed by them and will be part of 1.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants