Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some ideas #1

Open
StefanCohen opened this issue Oct 8, 2020 · 1 comment
Open

Some ideas #1

StefanCohen opened this issue Oct 8, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@StefanCohen
Copy link

StefanCohen commented Oct 8, 2020

This is a really nifty plugin. Especially for other plugin developers. I know this is in early development but I gave it a try and I really like it. I have some Ideas for improvements.

File destination setting: It would be great if you could set the destination path for the output files in the plugin settings. When running the plugin as a service (i.e OctoPi) the plugin will throw a permission error since it can't write to whatever the default destination folder is.

Module/Function filtering. You can use filter_callback on get_func_stats API to filter on functions, modules or whatever available in YFuncStat object. A setting to enable filtering and a filter string would reduce the noise. A drop-down that enumerates plugins and/or plugin methods would be a big plus.

Display text output in tab: You could add a tab view to the plugin and display the output of yappi.get_func_stats().print_all() there. The tab could even include start/stop buttons to profile OP between prints.

A pretty cool way of displaying the profiling result to the user is to transform the pstats output into a png using gprof2dot -f pstats test.pstats | dot -Tpng -o output.png. I guess that could be a way to analyse the results for those who don't have access other methods.

@gdombiak
Copy link
Owner

gdombiak commented Oct 8, 2020

Very nice ideas @StefanCohen! I had some of those in mind but you took it to the next level. :)

@gdombiak gdombiak added the enhancement New feature or request label Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants