Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnderlineStyle is displayed, but UnderlineColor is not #769

Closed
noborus opened this issue Jan 12, 2025 · 5 comments
Closed

UnderlineStyle is displayed, but UnderlineColor is not #769

noborus opened this issue Jan 12, 2025 · 5 comments

Comments

@noborus
Copy link
Contributor

noborus commented Jan 12, 2025

Thank you for adding support for UnderlineColor and UnderlineStyle.

I tried it, and in gnome-terminal, the UnderlineStyle change works, but the UnderlineColor color doesn't seem to work.
The gnome-terminal itself supports UnderlineColor, so it should reflect the underline color, for example, by running the following command:

TERM=xterm-ghostty go run ./_demos/style.go

Screenshot from 2025-01-12 09-11-15

Environment:

Ubuntu 24.04
gnome-terminal 3.52.0-1ubuntu2

@gdamore
Copy link
Owner

gdamore commented Jan 12, 2025

It's likely that a new terminal entry needs to be created for it. I will look when I have time.

@gdamore
Copy link
Owner

gdamore commented Jan 12, 2025

Can you tell me what is in your $TERM environment variable. I see mixed messaging around this...

@gdamore
Copy link
Owner

gdamore commented Jan 12, 2025

Yeah, I see, its xterm-256color probably. The code that looks for this expects an explicit entry in terminfo but not for the style. I'm fixing it.

@noborus
Copy link
Contributor Author

noborus commented Jan 12, 2025

When I started Gnome-Terminal normally, it was TERM=xterm-256color.

@gdamore gdamore changed the title UnderlineStyle is displayed, but UnderlineColor does not change in gnome-terminal UnderlineStyle is displayed, but UnderlineColor is not Jan 12, 2025
@noborus
Copy link
Contributor Author

noborus commented Jan 12, 2025

It has been fixed. thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants