Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evolve throws while absent of corresponding transformations #1718

Open
imcotton opened this issue Jun 8, 2022 · 1 comment · May be fixed by #1719
Open

evolve throws while absent of corresponding transformations #1718

imcotton opened this issue Jun 8, 2022 · 1 comment · May be fixed by #1719

Comments

@imcotton
Copy link
Contributor

imcotton commented Jun 8, 2022 •
edited
Loading

🐛 Bug report

Current Behavior

evolve from struct throws while having absent transformations:

node_modules/fp-ts/lib/struct.js:78
            out[k] = transformations[k](a[k]);
                                       ^

TypeError: transformations[k] is not a function
    at node_modules/fp-ts/lib/struct.js:78:40

Expected behavior

Leaves unspecified entries untouched.

Reproducible example

const { pipe, identity } = require('fp-ts/function')
const { singleton } = require('fp-ts/ReadonlyRecord')
const { evolve } = require('fp-ts/struct')

// Expected { a: 1 }
const result = pipe(
    singleton('a', 1),
    evolve({
        b: identity,
    }),
)

Suggested solution(s)

Check before invoking transformations.

Additional context

Expected behavior would align with the evolve from Ramda as well.

Your environment

Did this work in previous versions of fp-ts? no

Which versions of fp-ts are affected by this issue?

Software Version(s)
fp-ts 2.11
2.12
TypeScript 4.7


@imcotton imcotton linked a pull request Jun 8, 2022 that will close this issue
Open
@danielo515
Copy link

Ok, happy to see that I'm not the only one with this expectation. In fact, I expected the transformation struct to drive the logic completely, so all the functions are executed even if the passed value doesn't contain one of the keys (which TS should probably detect anyway).

Please note this is a problem because the structural typing nature of typescript, where you can pass extra properties without any type error, and this will fail at runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

struct: evolve to skip unspecified transformations imcotton/fp-ts
2 participants
@imcotton @danielo515