Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to add isConfidenceDefinite() to ParseResult #3

Open
cgendreau opened this issue Oct 27, 2015 · 2 comments
Open

Suggestion to add isConfidenceDefinite() to ParseResult #3

cgendreau opened this issue Oct 27, 2015 · 2 comments

Comments

@cgendreau
Copy link
Contributor

I suggest to add isConfidenceDefinite() to the ParseResult class to make the check less verbose. The method signature could also be hasConfidence(CONFIDENCE).

@timrobertson100
Copy link
Member

I wouldn't understand what either did based on name alone. Perhaps:

  /**
   * Returns true only if the determined confidence level exceeds the given threshold
   */
  public boolean confidenceExceeds(int threshold) {...}

@cgendreau
Copy link
Contributor Author

yes, good point, but the method should probably includes the threshold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants