Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated deprecation note from parser_urdf.hh #740

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Remove outdated deprecation note from parser_urdf.hh #740

merged 1 commit into from
Nov 4, 2021

Conversation

adlarkin
Copy link
Contributor

@adlarkin adlarkin commented Nov 4, 2021 •
edited
Loading

Signed-off-by: Ashton Larkin [email protected]

🦟 Bug fix

Addresses #736 (comment)

Summary

The discussion held in #736 (comment) pointed out that the URDF2SDF is actually not deprecated and is a private header that is needed, so I have removed the deprecation note from the class' header file.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@adlarkin adlarkin requested a review from scpeters November 4, 2021 18:36
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Nov 4, 2021
@adlarkin adlarkin mentioned this pull request Nov 4, 2021
Closed
8 tasks
@scpeters
Copy link
Member

scpeters commented Nov 4, 2021

I believe this comment was added in BitBucket pull request 658 and should have been removed in #276

@scpeters scpeters requested a review from azeey November 4, 2021 20:08
scpeters
scpeters approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added @azeey as a reviewer since he originally added this comment

azeey
azeey approved these changes Nov 4, 2021
View reviewed changes
Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this comment was added when we deprecated /include/sdf/parser_urdf.hh. It should have been removed when the file was moved to src/parser_urdf.hh.

@adlarkin adlarkin merged commit 2905643 into sdf10 Nov 4, 2021
@adlarkin adlarkin deleted the adlarkin/remove_urdf2sdf_deprecation branch November 4, 2021 21:36
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@azeey azeey azeey approved these changes

Assignees
No one assigned
Labels
🔮 dome Ignition Dome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adlarkin @scpeters @osrf-triage @azeey