Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support accessing mutable sensor types #737

Merged
merged 4 commits into from
Nov 2, 2021
Merged

Support accessing mutable sensor types #737

merged 4 commits into from
Nov 2, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Oct 29, 2021

🎉 New feature

Summary

I found a need for mutable sensor type accessors while working on sensor editing via the Ignition GUI. I'm putting this into sdf12 because the GUI modifications will be on Fortress, and there would be more work to get this into citadel.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Nate Koenig added 2 commits October 29, 2021 14:09
Signed-off-by: Nate Koenig <[email protected]>
@github-actions github-actions bot added 🌱 garden Ignition Garden 🏯 fortress Ignition Fortress labels Oct 29, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #737 (dfa0b04) into sdf12 (c9494fb) will decrease coverage by 0.11%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##            sdf12     #737      +/-   ##
==========================================
- Coverage   88.22%   88.11%   -0.12%     
==========================================
  Files          76       76              
  Lines       11437    11457      +20     
==========================================
+ Hits        10090    10095       +5     
- Misses       1347     1362      +15     
Impacted Files Coverage Δ
src/Sensor.cc 77.32% <12.50%> (-4.10%) ⬇️
src/Utils.hh 94.73% <0.00%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9494fb...dfa0b04. Read the comment docs.

src/Sensor_TEST.cc Outdated Show resolved Hide resolved
Signed-off-by: Nate Koenig <[email protected]>
Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I just have a few comments about the tests. Once those comments are addressed, feel free to merge!

src/Sensor_TEST.cc Show resolved Hide resolved
src/Sensor_TEST.cc Show resolved Hide resolved
Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig merged commit b240384 into sdf12 Nov 2, 2021
@nkoenig nkoenig deleted the mutable_sensors branch November 2, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress 🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants