Emit an error instead of a warning when a file has multiple root level model, actor or light elements #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
model, actor or light elements. Also, remove deprecated functions for accessing multiple model, actor or light elements from the Root DOM. Signed-off-by: Addisu Z. Taddese <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #619 +/- ##
==========================================
- Coverage 87.62% 87.59% -0.03%
==========================================
Files 72 72
Lines 10534 10513 -21
==========================================
- Hits 9230 9209 -21
Misses 1304 1304
Continue to review full report at Codecov.
|
marcoag
approved these changes
Jul 12, 2021
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#433 and #444 made it so that only one root level model, actor or light can be contained in an SDFormat file. So as to not break existing behavior, only a warning was issued if more than one is found. These have now been converted to errors. This PR also removes deprecated functions for accessing multiple model, actor or light elements from
sdf::Root.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge