Allow files paths for include URIs #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
//include/uri used to only take directories that contain a model.config file and the sdformat file. However, allowing //include/uri to take file names can be supported without loss of functionality. Signed-off-by: Addisu Z. Taddese <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
==========================================
+ Coverage 87.63% 87.66% +0.02%
==========================================
Files 63 63
Lines 9622 9620 -2
==========================================
+ Hits 8432 8433 +1
+ Misses 1190 1187 -3
Continue to review full report at Codecov.
|
brawner
approved these changes
Dec 24, 2020
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
EricCousineau-TRI
approved these changes
Jan 14, 2021
scpeters
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//include/uriused to only take directories that contain a model.config file and the sdformat file. However, allowing//include/urito take file names can be supported without loss of functionality and will allow users to specify non-sdformat files to include via the Interface API, when it's implemented.Toward #430