Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

//model should only allow one @canonical_link #703

Closed
FirefoxMetzger opened this issue Sep 20, 2021 · 2 comments · Fixed by #716
Closed

//model should only allow one @canonical_link #703

FirefoxMetzger opened this issue Sep 20, 2021 · 2 comments · Fixed by #716
Labels
bug Something isn't working

Comments

@FirefoxMetzger
Copy link
Contributor

FirefoxMetzger commented Sep 20, 2021

This is a fairly small thing. I think there is a typo in model.sdf for v1.7 and v1.8.

https://github.com/ignitionrobotics/sdformat/blob/5182c0e679ea19da0dfd356e9821b2d146e23d2c/sdf/1.7/model.sdf#L14

I think the required="*" should actually be a required="0", since - as far as I know - it is not possible for a model to have multiple canonical links. If so, I can submit a patch.

Edit: The reason I think this is a typo is because @canonical_link defines the link to which __model__ is @attached_to, and having multiple @canonical_links would make it possible to attach __model__ to multiple links.

@FirefoxMetzger FirefoxMetzger added the bug Something isn't working label Sep 20, 2021
@azeey
Copy link
Collaborator

azeey commented Sep 21, 2021

Yes, I think it should be required="0". Thanks for finding these issues.

@azeey
Copy link
Collaborator

azeey commented Jan 24, 2022

Closed by #716

@azeey azeey closed this as completed Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants