Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing SDF files in sdf/1.8/CMakeLists.txt #629

Closed
FirefoxMetzger opened this issue Jul 22, 2021 · 1 comment · Fixed by #631
Closed

Missing SDF files in sdf/1.8/CMakeLists.txt #629

FirefoxMetzger opened this issue Jul 22, 2021 · 1 comment · Fixed by #631
Labels
bug Something isn't working

Comments

@FirefoxMetzger
Copy link
Contributor

I've been toying with this repo because I want to create type-annotated python bindings for the SDFormat. Both for validation and for a better time while programming (IDE auto-completion). To make a long story short, I am generating python stub files from the schemas generated during this repo's build and the stub generator (external: xsdata) warns that a few class schemas could not be found for v1.8 (haven't tested others yet).

For some warnings the cause seems to trace back to CMakeLists.txt which is missing 3 SDFs:

  • lidar.sdf
  • air_pressure.sdf
  • particle_emitter.sdf

which leads to missing *.xsd files. Adding the respective lines solves this issue as expected and generates the missing *.xsd files.

Is this intentional or a bug? If the latter, I can submit a PR.

@FirefoxMetzger FirefoxMetzger added the bug Something isn't working label Jul 22, 2021
@chapulina
Copy link
Contributor

Nice catch, it's unintentional, these are the latest files added and were simply forgotten.

I want to create type-annotated python bindings for the SDFormat.

Nice! Let us (and the community) know when you're done, we'd love to try it out!

FirefoxMetzger added a commit to FirefoxMetzger/sdformat that referenced this issue Jul 23, 2021
FirefoxMetzger added a commit to FirefoxMetzger/sdformat that referenced this issue Jul 23, 2021
Closes: gazebosim#629
Signed-off-by: Sebastian Wallkötter <[email protected]>
chapulina pushed a commit that referenced this issue Jul 23, 2021
* BUG: add missing sdf files to CMakeLists

Closes: #629
Signed-off-by: Sebastian Wallkötter <[email protected]>
Signed-off-by: FirefoxMetzger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants