Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EnforcementPolicy: Shouldn't strictly turn deprecations into errors? #541

Closed
EricCousineau-TRI opened this issue Apr 14, 2021 · 0 comments · Fixed by #543
Closed

EnforcementPolicy: Shouldn't strictly turn deprecations into errors? #541

EricCousineau-TRI opened this issue Apr 14, 2021 · 0 comments · Fixed by #543
Labels
bug Something isn't working

Comments

@EricCousineau-TRI
Copy link
Collaborator

EricCousineau-TRI commented Apr 14, 2021 •
edited
Loading

Environment

N/A. Source code rather.

Description

  • Expected behavior: Devs / users should have knobs to let deprecations trigger warnings or errors, separate from (or extending) sdf::EnforcementPolicy::ERR.
  • Actual behavior: Deprecations are warnings, and turn into errors with sdf::EnforcementPolicy::ERR, which hurts libs that want to be strict, but still admit deprecations.

See: RobotLocomotion/drake#14852 (review)

Relates #481

Steps to reproduce

N/A

Output

N/A
@EricCousineau-TRI EricCousineau-TRI added the bug Something isn't working label Apr 14, 2021
@azeey azeey mentioned this issue Apr 21, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add an EnforcementPolicy for deprecated elements azeey/sdformat
1 participant
@EricCousineau-TRI