Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including an SDFormat model file containing multiple models is ambiguous #395

Closed
azeey opened this issue Oct 21, 2020 · 1 comment · Fixed by #433
Closed

Including an SDFormat model file containing multiple models is ambiguous #395

azeey opened this issue Oct 21, 2020 · 1 comment · Fixed by #433
Assignees

Comments

@azeey
Copy link
Collaborator

azeey commented Oct 21, 2020

According to the spec, an SDFormat model file can contain multiple models, i.e one can have:

<?xml version='1.0'?>
<sdf version='1.7'>
 <model name='model_1'>
    ...
 </model>
 <model name='model_2'>
    ...
 </model>
</sdf>

However, it is not clear what should happen when such a model file is used with the //include tag. Are both models included or just one? If both are included, which model do the overriding elements in //include (eg. //include/name, //include/pose) refer to?

@azeey
Copy link
Collaborator Author

azeey commented Oct 22, 2020

Per our discussion with @EricCousineau-TRI, @scpeters, and @sammy-tri, SDFormat files where the contents are //sdf/model, //sdf/actor, or //sdf/light should only contain one of those elements. The rationale is that these files can be included with //include while overriding some of their properties. Having multiple elements in the file would create confusion as to which element is being included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants