Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit detecting an element / attribute was explicitly set (user) or implicitly set (conversion / default value) #287

Closed
EricCousineau-TRI opened this issue May 16, 2020 · 3 comments
Assignees

Comments

@EricCousineau-TRI
Copy link
Collaborator

From discussion on 2020-01-23 on Asana.

Notes:
Default values

  • Know if a property was actually defined
  • libsdformat, in its conversion phase, substitutes in default values
  • Odd / non-strict value parsing (e.g. colors, RGBA)
  • API: Could add an attribute check, IsExplicitlySet() or UsedDefaultValue() or something, and have overloads for querying that uses optional<> or returns a flag
  • May be hard to check if a default value was actually set?
  • Could be useful for deprecating attributes that a user set?

\cc @SeanCurtis-TRI

@EricCousineau-TRI
Copy link
Collaborator Author

\cc @marcoag

@azeey
Copy link
Collaborator

azeey commented Jun 3, 2021

Waiting for #575 (comment) to be resolved before closing.

@marcoag
Copy link
Member

marcoag commented Jun 28, 2021

Resolved: #575 (comment). Closing this issue then.

@marcoag marcoag closed this as completed Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants