Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-parsed elements becoming (partially) parsed hurts existing downstream users? #267

Closed
EricCousineau-TRI opened this issue May 1, 2020 · 3 comments
Assignees

Comments

@EricCousineau-TRI
Copy link
Collaborator

Example issue pointed out here, which broke our functionality (upgrade from 9.1.x to 9.2.x):
RobotLocomotion/drake#13201 (comment)
In Drake, we were manually parsing //collision/surface/friction.

However, due to:
https://github.com/osrf/sdformat/blame/c6dac91c7845b0c45611e4db338e240bd86049d8/Changelog.md#L45-L46
https://github.com/osrf/sdformat/compare/a3468560e199a2723bf6ef544d338af82eea6871..76d1e4dc3257c6a529fa77b741b7fcdb67e0b1b6

For whatever reason, this same code path no longer works.
I currently cannot say why this has happened, as the raw XML should still be there (at least per the spec)?

I believe this is a bug, and should be fixed.

\cc @azeey @scpeters

@scpeters
Copy link
Member

scpeters commented May 1, 2020

I commented on the drake issue RobotLocomotion/drake#13201 (comment)

@scpeters
Copy link
Member

scpeters commented May 2, 2020

I've submitted a reversal of the recent behavior change in #268, but I think the drake code is brittle and should be improved.

@scpeters
Copy link
Member

I think the behavior change was fixed by #268 and upstream drake code is being updated as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants