Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

composition: Should mention that explicitly flattened models may break #39

Closed
EricCousineau-TRI opened this issue Aug 27, 2020 · 1 comment · Fixed by #41
Closed

composition: Should mention that explicitly flattened models may break #39

EricCousineau-TRI opened this issue Aug 27, 2020 · 1 comment · Fixed by #41
Assignees
@EricCousineau-TRI
Milestone
SDFormat 1.8 / li...

Comments

@EricCousineau-TRI
Copy link
Collaborator

For worlds that are saved, they may be flattened, and thus will use the reserved delimiter.

Solutions:

  • Don't fix it. Just tell users to go back to the world that used //include.
  • Fix it with the inverse of libsdformat9's addNestedModels, but call explicitly (e.g. ign sdf convert --unnest)
  • Same as above, but implicitly in standard conversion process
@EricCousineau-TRI EricCousineau-TRI self-assigned this Aug 27, 2020
@EricCousineau-TRI
Copy link
Collaborator Author

Er, just realized we discussed this in gazebosim/sdformat#355. Should be resolved by #41

\cc @azeey @scpeters

@EricCousineau-TRI EricCousineau-TRI mentioned this issue Sep 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EricCousineau-TRI EricCousineau-TRI

Labels
None yet
Projects
None yet
Milestone
SDFormat 1.8 / libsdformat11
Development

Successfully merging a pull request may close this issue.

composition: Add section for up-converting unflattened models EricCousineau-TRI/sdf_tutorials
1 participant
@EricCousineau-TRI