From 660964806dec7a75fd7544deceeda5e2d67193e0 Mon Sep 17 00:00:00 2001 From: Steve Peters Date: Wed, 12 Aug 2020 23:05:16 -0700 Subject: [PATCH] Improve phrasing, suggested edits Signed-off-by: Steve Peters --- pose_frame_semantics/proposal.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pose_frame_semantics/proposal.md b/pose_frame_semantics/proposal.md index 8ba1c1c..b1a7156 100644 --- a/pose_frame_semantics/proposal.md +++ b/pose_frame_semantics/proposal.md @@ -879,9 +879,9 @@ the implicit world frame. {X_FN} - + - + {X_NF0} @@ -1549,7 +1549,7 @@ returning an error code if errors are found during parsing: representing a frame (see [buildFrameAttachedToGraph](https://github.com/osrf/sdformat/blob/sdformat9_9.2.0/src/FrameSemantics.cc#L168) in `libsdformat9`): - 7.1 Add a vertex for the implicit frame of each `//link`, + 7.1 Add a vertex for the frame of each `//link`, `//joint`, `//frame`, and nested `//model` in the model (see [FrameSemantics.cc:219-233](https://github.com/osrf/sdformat/blob/sdformat9_9.2.0/src/FrameSemantics.cc#L219-L233), [FrameSemantics.cc:271-286](https://github.com/osrf/sdformat/blob/sdformat9_9.2.0/src/FrameSemantics.cc#L271-L286), @@ -1568,13 +1568,13 @@ returning an error code if errors are found during parsing: 7.4 For each `//model/frame`: 7.4.1 If `//model/frame/@attached_to` exists and is not empty, - add an edge from the added vertex to the vertex + add an edge from this frame's vertex to the vertex named in the `//model/frame/@attached_to` attribute (see [FrameSemantics.cc:288-322](https://github.com/osrf/sdformat/blob/sdformat9_9.2.0/src/FrameSemantics.cc#L288-L322)). 7.4.2 Otherwise (i.e. if the `//model/frame/@attached_to` attribute does not exist or is an empty string `""`), - add an edge from the added vertex to the model frame vertex, + add an edge from this frame's vertex to the model frame vertex, (see [FrameSemantics.cc:288-322](https://github.com/osrf/sdformat/blob/sdformat9_9.2.0/src/FrameSemantics.cc#L288-L322)). 7.5 Verify that the graph has no cycles and that by following the directed